Skip to content

Fix StrictArrayParamDimFetchRector on is_* calls#4486

Merged
samsonasik merged 6 commits intorectorphp:mainfrom
staabm:patch-2
Jul 12, 2023
Merged

Fix StrictArrayParamDimFetchRector on is_* calls#4486
samsonasik merged 6 commits intorectorphp:mainfrom
staabm:patch-2

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Jul 12, 2023

rector adds a native array type, which is no correct as the method also accepts a regular string

https://getrector.com/demo/5e9396b2-0a09-4570-875c-e69e32eed1bf

@staabm staabm requested a review from TomasVotruba as a code owner July 12, 2023 07:38
@staabm staabm changed the title StrictArrayParamDimFetchRector failing test Fix StrictArrayParamDimFetchRector on is_* calls Jul 12, 2023
@samsonasik samsonasik merged commit d4a432e into rectorphp:main Jul 12, 2023
@samsonasik
Copy link
Copy Markdown
Member

Thank you @staabm

@TomasVotruba
Copy link
Copy Markdown
Member

Thank you @staabm 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants